storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] kishorvpatil commented on a change in pull request #3306: STORM-3671: Add TopologySummary methods to Nimbus
Date Mon, 20 Jul 2020 18:53:00 GMT

kishorvpatil commented on a change in pull request #3306:
URL: https://github.com/apache/storm/pull/3306#discussion_r457622150



##########
File path: storm-client/src/jvm/org/apache/storm/security/auth/authorizer/SimpleACLAuthorizer.java
##########
@@ -40,6 +40,11 @@
         "fileUpload",
         "getNimbusConf",
         "getClusterInfo",
+        "getLeader",
+        "isTopologyNameAllowed",
+        "getTopologySummaries",
+        "getTopologySummaryByName",
+        "getTopologySummary",

Review comment:
       All variations for for _getTopologyInfo_ method are using _getTopologyInfo_ for now.
I do not intend to change implementation _getTopologyInfoWithOptsImpl_ at this point to refactor
checkAuthorization else where.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message