storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] Ethanlm commented on a change in pull request #3295: STORM-3660: Remove use of queues for updating credentials
Date Thu, 09 Jul 2020 17:51:24 GMT

Ethanlm commented on a change in pull request #3295:
URL: https://github.com/apache/storm/pull/3295#discussion_r452389342



##########
File path: storm-client/src/jvm/org/apache/storm/executor/Executor.java
##########
@@ -124,6 +126,7 @@
     protected int idToTaskBase;
     protected String hostname;
     private static final double msDurationFactor = 1.0 / TimeUnit.MILLISECONDS.toNanos(1);
+    private boolean needToRefreshCreds = true;

Review comment:
       If only simple `get()` and `set()` methods are used in `AtomicBoolean`, it is basically
the same as using `volatile boolean` unless methods like `compareAndSet` and `getAndSet` are
required. 
   https://github.com/AdoptOpenJDK/openjdk-jdk8u/blob/master/jdk/src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java#L85-L87
(although the implementation uses `volatile int`)
   
   
   But anyway, using `AtomicBoolean` is easier to understand.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message