Ethanlm commented on pull request #3303:
URL: https://github.com/apache/storm/pull/3303#issuecomment-654978965
> The change looks okay except, the validation should be performed only if Nimbus is
using ResourceAwareSchduler
> https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L3150
>
> Some condition like should help avoid that `if (underlyingScheduler instanceof ResourceAwareScheduler)`
I will file a separate Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
|