storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] kishorvpatil commented on a change in pull request #3295: STORM-3660: Remove use of queues for updating credentials
Date Wed, 01 Jul 2020 14:05:35 GMT

kishorvpatil commented on a change in pull request #3295:
URL: https://github.com/apache/storm/pull/3295#discussion_r448387076



##########
File path: storm-client/src/jvm/org/apache/storm/executor/Executor.java
##########
@@ -270,6 +273,15 @@ public ExecutorShutdown execute() throws Exception {
 
     @Override
     public void accept(Object event) {
+        if (this.needToRefreshCreds) {

Review comment:
       moved this to separate method and being called fro withing `BoltExecutor` and `SpoutExecutor`
call at the beginning of each iteration in the asyncloop. This would ensure that credentials
are updated on executor irrespective of back pressure or no tuples to process scenarios. For
backward compatibility and agreement about invoking _setCreentials_ on user implementation
on _ICredentialsListener_ from executor thread, if Executor thread is stuck in _execute_ or
_nextTuple_  methods delays can not be avoided. But otherwise we should be able to get credentials
update on next iteration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message