From dev-return-61061-archive-asf-public=cust-asf.ponee.io@storm.apache.org Thu Nov 21 16:10:46 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9CC24180660 for ; Thu, 21 Nov 2019 17:10:46 +0100 (CET) Received: (qmail 79762 invoked by uid 500); 21 Nov 2019 16:10:45 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 79750 invoked by uid 99); 21 Nov 2019 16:10:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Nov 2019 16:10:45 +0000 From: GitBox To: dev@storm.apache.org Subject: [GitHub] [storm] srdo commented on a change in pull request #3169: STORM-3540 fix Pacemaker connection issues Message-ID: <157435264555.5724.12763977181560555495.gitbox@gitbox.apache.org> Date: Thu, 21 Nov 2019 16:10:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit srdo commented on a change in pull request #3169: STORM-3540 fix Pacemaker connection issues URL: https://github.com/apache/storm/pull/3169#discussion_r349176921 ########## File path: storm-client/src/jvm/org/apache/storm/pacemaker/codec/ThriftNettyClientCodec.java ########## @@ -72,7 +72,7 @@ protected void initChannel(Channel ch) throws Exception { throw new RuntimeException(e); } } else { - client.channelReady(ch); + // no work for AuthMethod.NONE Review comment: Consider removing the else block entirely ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services