From dev-return-61058-archive-asf-public=cust-asf.ponee.io@storm.apache.org  Wed Nov 20 21:57:50 2019
Return-Path: <dev-return-61058-archive-asf-public=cust-asf.ponee.io@storm.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id CB9661804BB
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 20 Nov 2019 22:57:49 +0100 (CET)
Received: (qmail 63529 invoked by uid 500); 20 Nov 2019 21:57:49 -0000
Mailing-List: contact dev-help@storm.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@storm.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@storm.apache.org>
List-Post: <mailto:dev@storm.apache.org>
List-Id: <dev.storm.apache.org>
Reply-To: dev@storm.apache.org
Delivered-To: mailing list dev@storm.apache.org
Received: (qmail 63517 invoked by uid 99); 20 Nov 2019 21:57:48 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Nov 2019 21:57:48 +0000
From: GitBox <git@apache.org>
To: dev@storm.apache.org
Subject: [GitHub] [storm] dandsager1 commented on a change in pull request #3163:
 STORM-3534 Add generic resources to UI
Message-ID: <157428706883.23416.5707967379095210861.gitbox@gitbox.apache.org>
Date: Wed, 20 Nov 2019 21:57:48 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

dandsager1 commented on a change in pull request #3163: STORM-3534 Add generic resources to UI
URL: https://github.com/apache/storm/pull/3163#discussion_r348766587
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/normalization/NormalizedResourceRequest.java
 ##########
 @@ -178,6 +178,43 @@ private static void putIfMissing(Map<String, Double> dest, String destKey, Map<S
         return ret;
     }
 
+    /*
+     * return map with non generic resources removded
+     */
+    public static void filterGenericResources(Map<String, Double> map) {
 
 Review comment:
   renamed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services