From dev-return-61045-archive-asf-public=cust-asf.ponee.io@storm.apache.org Fri Nov 15 15:50:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3822B180658 for ; Fri, 15 Nov 2019 16:50:08 +0100 (CET) Received: (qmail 9245 invoked by uid 500); 15 Nov 2019 15:50:07 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 9232 invoked by uid 99); 15 Nov 2019 15:50:06 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Nov 2019 15:50:06 +0000 From: GitBox To: dev@storm.apache.org Subject: [GitHub] [storm] dandsager1 commented on a change in pull request #3167: STORM-3538 Add Meter for sendSupervisorAssignments exception Message-ID: <157383300681.27955.2025559683006418066.gitbox@gitbox.apache.org> Date: Fri, 15 Nov 2019 15:50:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dandsager1 commented on a change in pull request #3167: STORM-3538 Add Meter for sendSupervisorAssignments exception URL: https://github.com/apache/storm/pull/3167#discussion_r346887634 ########## File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ########## @@ -1654,6 +1657,10 @@ private AssignmentDistributionService getAssignmentsDistributer() { return assignmentsDistributer; } + private StormMetricsRegistry getMetricsRegistry() { Review comment: It's used to access class member in static methods in the same way nimbus.getAssignmentsDistributer(). I'm fine with using the member directly but then should do the same with getAssignmentsDistributer() ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services