storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] dandsager1 commented on a change in pull request #3167: STORM-3538 Add Meter for sendSupervisorAssignments exception
Date Fri, 15 Nov 2019 15:50:06 GMT
dandsager1 commented on a change in pull request #3167: STORM-3538 Add Meter for sendSupervisorAssignments
exception
URL: https://github.com/apache/storm/pull/3167#discussion_r346887634
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
 ##########
 @@ -1654,6 +1657,10 @@ private AssignmentDistributionService getAssignmentsDistributer()
{
         return assignmentsDistributer;
     }
 
+    private StormMetricsRegistry getMetricsRegistry() {
 
 Review comment:
   It's used to access class member in static methods in the same way nimbus.getAssignmentsDistributer().
   
   I'm fine with using the member directly but then should do the same with getAssignmentsDistributer()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message