storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] jacobtolar commented on issue #3165: 'kafkaSpoutConfig' can be 'protected'
Date Thu, 14 Nov 2019 23:35:19 GMT
jacobtolar commented on issue #3165: 'kafkaSpoutConfig' can be 'protected'
URL: https://github.com/apache/storm/pull/3165#issuecomment-554134941
 
 
   @srdo Thanks for the thoughts. 
   
   In our case, we just want to get at the record translator inside 'open' from the config.
We actually just need its streams for our current use case. What we're doing is creating per-stream
metrics in the spout. When acking is on, we produce a histogram of total time a given tuple
spends in the topology (by stream) from appearing in the spout until it acks or fails.
   
   What we have works, it always just feels silly keeping another reference to something already
in the parent.
   
   It sounds like you'd prefer something like an overridable hook called at the end of open()
that passes in the config or list of streams or something?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message