storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] srdo commented on issue #3165: 'kafkaSpoutConfig' can be 'protected'
Date Wed, 13 Nov 2019 15:57:41 GMT
srdo commented on issue #3165: 'kafkaSpoutConfig' can be 'protected'
URL: https://github.com/apache/storm/pull/3165#issuecomment-553466659
 
 
   I'm not sure about this. The spout wasn't really written with subclassing in mind, and
the majority of the implementation is private. I also don't think we want to guarantee that
we won't break the internal implementation of the spout in minor/patch releases. If you have
a use case, maybe we could add a hook somewhere instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message