srdo commented on a change in pull request #3150: STORM-3528: Allow users to provide their
own custom TriggerPolicy/EvictionPolicy in BaseWindowBolt
URL: https://github.com/apache/storm/pull/3150#discussion_r341804793
##########
File path: storm-client/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java
##########
@@ -205,10 +205,21 @@ protected void validate(Map<String, Object> topoConf, Count windowLengthCount,
D
}
// validate
validate(topoConf, windowLengthCount, windowLengthDuration,
- slidingIntervalCount, slidingIntervalDuration);
- evictionPolicy = getEvictionPolicy(windowLengthCount, windowLengthDuration);
- triggerPolicy = getTriggerPolicy(slidingIntervalCount, slidingIntervalDuration,
- manager, evictionPolicy);
+ slidingIntervalCount, slidingIntervalDuration);
+ if (topoConf.containsKey(Config.TOPOLOGY_BOLTS_WINDOW_EVICTION_POLICY)
+ && topoConf.get(Config.TOPOLOGY_BOLTS_WINDOW_EVICTION_POLICY) instanceof
EvictionPolicy) {
Review comment:
I don't think you need to do the instanceof check here, we already specify that it needs
to be that type in Config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
|