From dev-return-60888-archive-asf-public=cust-asf.ponee.io@storm.apache.org Tue Oct 15 17:59:21 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DBCA1180651 for ; Tue, 15 Oct 2019 19:59:20 +0200 (CEST) Received: (qmail 38818 invoked by uid 500); 15 Oct 2019 17:59:20 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 38807 invoked by uid 99); 15 Oct 2019 17:59:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Oct 2019 17:59:19 +0000 From: GitBox To: dev@storm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bstorm=5D_agresch_opened_a_new_pull_request_=233?= =?utf-8?q?144=3A_STORM-3524_create_complete_blobstore_path_in_case_parent?= =?utf-8?q?_directory_ge=E2=80=A6?= Message-ID: <157116235986.29673.10060162939386276556.gitbox@gitbox.apache.org> Date: Tue, 15 Oct 2019 17:59:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit agresch opened a new pull request #3144: STORM-3524 create complete blobstore path in case parent directory ge… URL: https://github.com/apache/storm/pull/3144 …ts deleted Based on the exception I saw on a supervisor, I think a race condition existed between a cleanup of the localizer for an older topology and a new one starting where a parent directory was deleted right before a download. Files.createDirectory() then throws an exception because the parent directory does not exist and can never succeed. Files.createDirectories() should guarantee the directory gets created. Also added logging for removing the user to better debug in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services