From dev-return-60847-archive-asf-public=cust-asf.ponee.io@storm.apache.org Thu Oct 3 14:05:47 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BCF6F18065B for ; Thu, 3 Oct 2019 16:05:46 +0200 (CEST) Received: (qmail 64636 invoked by uid 500); 3 Oct 2019 14:05:43 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 64422 invoked by uid 99); 3 Oct 2019 14:05:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Oct 2019 14:05:42 +0000 From: GitBox To: dev@storm.apache.org Subject: [GitHub] [storm] Ethanlm commented on a change in pull request #3132: STORM-3186: Customizable configuration for metric reporting interval Message-ID: <157011154254.17268.5333623141371839920.gitbox@gitbox.apache.org> Date: Thu, 03 Oct 2019 14:05:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Ethanlm commented on a change in pull request #3132: STORM-3186: Customizable configuration for metric reporting interval URL: https://github.com/apache/storm/pull/3132#discussion_r331057431 ########## File path: storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/ConsolePreparableReporter.java ########## @@ -46,13 +50,14 @@ public void prepare(MetricRegistry metricsRegistry, Map topoConf builder.convertDurationsTo(durationUnit); } reporter = builder.build(); + reportingIntervalPeriod = ObjectReader.getInt(topoConf.get(DaemonConfig.STORM_DAEMON_METRICS_REPORTER_INTERVAL_SECS), 10); Review comment: Agreed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services