storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] govind-menon commented on a change in pull request #3141: STORM-3518: Add support to (un)favored nodes with range format
Date Mon, 14 Oct 2019 15:05:59 GMT
govind-menon commented on a change in pull request #3141: STORM-3518: Add support to (un)favored
nodes with range format
URL: https://github.com/apache/storm/pull/3141#discussion_r334528402
 
 

 ##########
 File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java
 ##########
 @@ -628,7 +628,7 @@ public void testMultipleRacksWithFavoritism() {
         t1Conf.putAll(config);
         final List<String> t1FavoredHostNames = Arrays.asList("host-41", "host-42",
"host-43");
         t1Conf.put(Config.TOPOLOGY_SCHEDULER_FAVORED_NODES, t1FavoredHostNames);
-        final List<String> t1UnfavoredHostIds = Arrays.asList("host-1", "host-2", "host-3");
+        final List<String> t1UnfavoredHostIds = Arrays.asList("host-1", "host-2", "host-3",
"host[11-13]", "host[2-1]");
 
 Review comment:
   Could we add an assert to check the correct host ids were unfavored?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message