storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] Ethanlm commented on a change in pull request #3132: STORM-3186: Customizable configuration for metric reporting interval
Date Thu, 03 Oct 2019 14:05:42 GMT
Ethanlm commented on a change in pull request #3132: STORM-3186: Customizable configuration
for metric reporting interval
URL: https://github.com/apache/storm/pull/3132#discussion_r331057431
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/ConsolePreparableReporter.java
 ##########
 @@ -46,13 +50,14 @@ public void prepare(MetricRegistry metricsRegistry, Map<String, Object>
topoConf
             builder.convertDurationsTo(durationUnit);
         }
         reporter = builder.build();
+        reportingIntervalPeriod = ObjectReader.getInt(topoConf.get(DaemonConfig.STORM_DAEMON_METRICS_REPORTER_INTERVAL_SECS),
10);
 
 Review comment:
   Agreed 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message