storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] Ethanlm commented on a change in pull request #3132: STORM-3186: Customizable configuration for metric reporting interval
Date Thu, 03 Oct 2019 14:05:42 GMT
Ethanlm commented on a change in pull request #3132: STORM-3186: Customizable configuration
for metric reporting interval
URL: https://github.com/apache/storm/pull/3132#discussion_r331057838
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/CsvPreparableReporter.java
 ##########
 @@ -18,14 +18,18 @@
 import java.util.Locale;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
+
+import org.apache.storm.DaemonConfig;
 import org.apache.storm.daemon.metrics.ClientMetricsUtils;
 import org.apache.storm.daemon.metrics.MetricsUtils;
+import org.apache.storm.utils.ObjectReader;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public class CsvPreparableReporter implements PreparableReporter {
     private static final Logger LOG = LoggerFactory.getLogger(CsvPreparableReporter.class);
     CsvReporter reporter = null;
+    Integer reportingIntervalPeriod = null;
 
 Review comment:
   here too: It would be better to change reportingIntervalPeriod to reportingIntervalSecs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message