From dev-return-60438-archive-asf-public=cust-asf.ponee.io@storm.apache.org Sat Aug 10 17:51:22 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5DB52180607 for ; Sat, 10 Aug 2019 19:51:22 +0200 (CEST) Received: (qmail 46080 invoked by uid 500); 10 Aug 2019 17:51:21 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 46069 invoked by uid 99); 10 Aug 2019 17:51:21 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Aug 2019 17:51:21 +0000 From: GitBox To: dev@storm.apache.org Subject: [GitHub] [storm] krichter722 commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings Message-ID: <156545948118.4823.10966169171489976741.gitbox@gitbox.apache.org> Date: Sat, 10 Aug 2019 17:51:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit krichter722 commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3050#discussion_r312710743 ########## File path: storm-server/src/main/java/org/apache/storm/pacemaker/PacemakerServer.java ########## @@ -90,6 +90,7 @@ public PacemakerServer(IServerMessageHandler handler, Map config this.bossEventLoopGroup = new NioEventLoopGroup(1, bossFactory); // 0 means DEFAULT_EVENT_LOOP_THREADS // https://github.com/netty/netty/blob/netty-4.1.24.Final/transport/src/main/java/io/netty/channel/MultithreadEventLoopGroup.java#L40 + int maxWorkers = (int) config.get(DaemonConfig.PACEMAKER_MAX_THREADS); Review comment: @d2r I don't get where the line `int maxWorkers` ought to be placed? Above the two comment lines, below or in between? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services