From dev-return-60437-archive-asf-public=cust-asf.ponee.io@storm.apache.org  Sat Aug 10 17:46:18 2019
Return-Path: <dev-return-60437-archive-asf-public=cust-asf.ponee.io@storm.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 1BF9C180607
	for <archive-asf-public@cust-asf.ponee.io>; Sat, 10 Aug 2019 19:46:18 +0200 (CEST)
Received: (qmail 40859 invoked by uid 500); 10 Aug 2019 17:46:17 -0000
Mailing-List: contact dev-help@storm.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@storm.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@storm.apache.org>
List-Post: <mailto:dev@storm.apache.org>
List-Id: <dev.storm.apache.org>
Reply-To: dev@storm.apache.org
Delivered-To: mailing list dev@storm.apache.org
Received: (qmail 40848 invoked by uid 99); 10 Aug 2019 17:46:17 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Aug 2019 17:46:17 +0000
From: GitBox <git@apache.org>
To: dev@storm.apache.org
Subject: [GitHub] [storm] krichter722 commented on a change in pull request #3050:
 STORM-3434: server: fix all checkstyle warnings
Message-ID: <156545917693.2938.9516860442898599530.gitbox@gitbox.apache.org>
Date: Sat, 10 Aug 2019 17:46:16 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

krichter722 commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings
URL: https://github.com/apache/storm/pull/3050#discussion_r312710620
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/utils/ServerUtils.java
 ##########
 @@ -214,13 +219,6 @@ public static ClientBlobStore getClientBlobStoreForSupervisor(Map<String, Object
 
     /**
      * Meant to be called only by the supervisor for stormjar/stormconf/stormcode files.
-     *
-     * @param key
-     * @param localFile
-     * @param cb
-     * @throws AuthorizationException
-     * @throws KeyNotFoundException
-     * @throws IOException
 
 Review comment:
   They have have no description and thus no value. Leaving them empty is refused by checkstyle (which is a good thing imo).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services