From dev-return-60434-archive-asf-public=cust-asf.ponee.io@storm.apache.org Sat Aug 10 17:38:33 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E3559180607 for ; Sat, 10 Aug 2019 19:38:32 +0200 (CEST) Received: (qmail 30570 invoked by uid 500); 10 Aug 2019 17:38:25 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 30132 invoked by uid 99); 10 Aug 2019 17:38:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Aug 2019 17:38:25 +0000 From: GitBox To: dev@storm.apache.org Subject: [GitHub] [storm] d2r commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings Message-ID: <156545870525.32195.13940063638307339245.gitbox@gitbox.apache.org> Date: Sat, 10 Aug 2019 17:38:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit d2r commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3050#discussion_r312709977 ########## File path: storm-server/src/main/java/org/apache/storm/localizer/LocalizedResourceRetentionSet.java ########## @@ -134,6 +134,7 @@ public String toString() { return "Cache: " + currentSize; } + @SuppressWarnings("checkstyle:AbbreviationAsWordInName") Review comment: I appreciate the judicious use of these suppressions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services