From dev-return-60409-archive-asf-public=cust-asf.ponee.io@storm.apache.org Thu Aug 8 14:18:10 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0CA09180642 for ; Thu, 8 Aug 2019 16:18:09 +0200 (CEST) Received: (qmail 22174 invoked by uid 500); 8 Aug 2019 14:18:03 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 21976 invoked by uid 99); 8 Aug 2019 14:18:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Aug 2019 14:18:02 +0000 From: GitBox To: dev@storm.apache.org Subject: [GitHub] [storm] Ethanlm commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option Message-ID: <156527388244.16584.15618146944012276759.gitbox@gitbox.apache.org> Date: Thu, 08 Aug 2019 14:18:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Ethanlm commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option URL: https://github.com/apache/storm/pull/3096#discussion_r312060599 ########## File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java ########## @@ -93,31 +104,119 @@ public TestDNSToSwitchMapping(Map ... racks) { } }; - @Rule - public NormalizedResourcesRule nrRule = new NormalizedResourcesRule(); - - @After + @AfterEach public void cleanup() { if (scheduler != null) { scheduler.cleanup(); scheduler = null; } } + /* + * test assigned memory with shared memory types and oneWorkerPerExecutor + */ + @ParameterizedTest + @EnumSource(TestDefaultResourceAwareStrategy.sharedMemoryTypes.class) + public void testMultipleSharedMemoryWithOneWorkerPerExecutor(sharedMemoryTypes memoryType) { + int spoutParallelism = 4; + double cpuPercent = 10; + double memoryOnHeap = 10; + double memoryOffHeap = 10; + double sharedOnHeap = 450; + double sharedOffHeapNode = 600; + double sharedOffHeapWorker = 400; + + TopologyBuilder builder = new TopologyBuilder(); + switch (memoryType) { + case SHARED_OFF_HEAP_NODE_TYPE: + builder.setSpout("spout", new TestSpout(), spoutParallelism) + .addSharedMemory(new SharedOffHeapWithinNode(sharedOffHeapNode, "spout shared node")); Review comment: Should at least include "off heap" to make it more clear ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services