From dev-return-60404-archive-asf-public=cust-asf.ponee.io@storm.apache.org Thu Aug 8 14:18:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3EA80180674 for ; Thu, 8 Aug 2019 16:18:03 +0200 (CEST) Received: (qmail 21636 invoked by uid 500); 8 Aug 2019 14:18:01 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 21582 invoked by uid 99); 8 Aug 2019 14:18:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Aug 2019 14:18:01 +0000 From: GitBox To: dev@storm.apache.org Subject: [GitHub] [storm] Ethanlm commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option Message-ID: <156527388146.16565.12034729371375520783.gitbox@gitbox.apache.org> Date: Thu, 08 Aug 2019 14:18:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Ethanlm commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option URL: https://github.com/apache/storm/pull/3096#discussion_r311771959 ########## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java ########## @@ -54,6 +54,7 @@ public abstract class BaseResourceAwareStrategy implements IStrategy { private static final Logger LOG = LoggerFactory.getLogger(BaseResourceAwareStrategy.class); protected Cluster cluster; + private boolean oneWorkerPerExecutor = false; Review comment: This would be `oneExecutorPerWorker` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services