From dev-return-60385-archive-asf-public=cust-asf.ponee.io@storm.apache.org Wed Aug 7 09:02:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1B436180643 for ; Wed, 7 Aug 2019 11:02:06 +0200 (CEST) Received: (qmail 8561 invoked by uid 500); 7 Aug 2019 09:02:04 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 8537 invoked by uid 99); 7 Aug 2019 09:02:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Aug 2019 09:02:04 +0000 From: GitBox To: dev@storm.apache.org Subject: [GitHub] [storm] srdo commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option Message-ID: <156516852437.27474.1547098807330171084.gitbox@gitbox.apache.org> Date: Wed, 07 Aug 2019 09:02:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit srdo commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option URL: https://github.com/apache/storm/pull/3096#discussion_r311437770 ########## File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java ########## @@ -120,198 +128,194 @@ public void testMultipleSharedMemoryWithOneWorkerPerExecutor() { double sharedOffHeapNode = 600; double sharedOffHeapWorker = 400; - for (sharedMemoryTypes memoryType : sharedMemoryTypes.values()) { - TopologyBuilder builder = new TopologyBuilder(); - switch (memoryType) { - case sharedOffHeapNodeType: - builder.setSpout("spout", new TestSpout(), spoutParallelism). - addSharedMemory(new SharedOffHeapWithinNode(sharedOffHeapNode, "spout shared node")); - break; - case sharedOffHeapWorkerType: - builder.setSpout("spout", new TestSpout(), spoutParallelism). - addSharedMemory(new SharedOffHeapWithinWorker(sharedOffHeapWorker, "spout shared off heap worker")); - break; - case sharedOnHeapType: - builder.setSpout("spout", new TestSpout(), spoutParallelism). - addSharedMemory(new SharedOnHeap(sharedOnHeap, "spout shared worker")); - break; - } - StormTopology stormToplogy = builder.createTopology(); - INimbus iNimbus = new INimbusTest(); - Map supMap = genSupervisors(4, 4, 500, 1000); - Config conf = createClusterConfig(cpuPercent, memoryOnHeap, memoryOffHeap, null); - - conf.put(Config.TOPOLOGY_PRIORITY, 0); - conf.put(Config.TOPOLOGY_NAME, "testTopology"); - conf.put(Config.TOPOLOGY_WORKER_MAX_HEAP_SIZE_MB, 2000); - conf.put(Config.TOPOLOGY_RAS_ONE_WORKER_PER_EXECUTOR, true); - TopologyDetails topo = new TopologyDetails("testTopology-id", conf, stormToplogy, 0, - genExecsAndComps(stormToplogy), CURRENT_TIME, "user"); + TopologyBuilder builder = new TopologyBuilder(); + switch (memoryType) { + case SHARED_OFF_HEAP_NODE_TYPE: + builder.setSpout("spout", new TestSpout(), spoutParallelism). Review comment: Nit: The last dot should go on the next line. I'm surprised checkstyle doesn't catch this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services