From dev-return-60381-archive-asf-public=cust-asf.ponee.io@storm.apache.org Tue Aug 6 18:22:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 46A39180181 for ; Tue, 6 Aug 2019 20:22:27 +0200 (CEST) Received: (qmail 26259 invoked by uid 500); 6 Aug 2019 18:22:26 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 26244 invoked by uid 99); 6 Aug 2019 18:22:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Aug 2019 18:22:26 +0000 From: GitBox To: dev@storm.apache.org Subject: [GitHub] [storm] Ethanlm commented on a change in pull request #3097: STORM-3475 Add ConstraintSolverStrategy Unit Test Message-ID: <156511574621.11237.8308379796532241565.gitbox@gitbox.apache.org> Date: Tue, 06 Aug 2019 18:22:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Ethanlm commented on a change in pull request #3097: STORM-3475 Add ConstraintSolverStrategy Unit Test URL: https://github.com/apache/storm/pull/3097#discussion_r311192170 ########## File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestConstraintSolverStrategy.java ########## @@ -194,6 +196,51 @@ protected SolverResult backtrackSearch(SearcherState state) { } } + /* + * Test scheduling large number of executors and constraints. + * + * Cluster has sufficient resources for scheduling to succeed but can fail due to StackOverflowError. + */ + @ParameterizedTest + @ValueSource(ints = { 5, 20 }) + public void testScheduleLargeExecutorConstraintCount(int parallelismMultiplier) + { Review comment: nit: should be no newline before `{` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services