srdo commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option
URL: https://github.com/apache/storm/pull/3096#discussion_r311436627
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/RAS_Node.java
 ##########
 @@ -170,6 +171,14 @@ public String getHostname() {
         return ret;
     }
 
+    public Collection<WorkerSlot> getUsedSlotsNonNull(String topoId) {
 
 Review comment:
   Nit: Any reason not to use this version everywhere? We could probably just change the existing version to return empty set.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services