From dev-return-60367-apmail-storm-dev-archive=storm.apache.org@storm.apache.org Sat Aug 3 08:47:08 2019 Return-Path: X-Original-To: apmail-storm-dev-archive@minotaur.apache.org Delivered-To: apmail-storm-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 9577519AAD for ; Sat, 3 Aug 2019 08:47:06 +0000 (UTC) Received: (qmail 89592 invoked by uid 500); 3 Aug 2019 08:46:56 -0000 Delivered-To: apmail-storm-dev-archive@storm.apache.org Received: (qmail 89186 invoked by uid 500); 3 Aug 2019 08:46:56 -0000 Mailing-List: contact dev-help@storm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.apache.org Delivered-To: mailing list dev@storm.apache.org Received: (qmail 88920 invoked by uid 99); 3 Aug 2019 08:46:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Aug 2019 08:46:55 +0000 From: GitBox To: dev@storm.apache.org Subject: [GitHub] [storm] srdo commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option Message-ID: <156482201568.30585.16318307289820761068.gitbox@gitbox.apache.org> Date: Sat, 03 Aug 2019 08:46:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit srdo commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option URL: https://github.com/apache/storm/pull/3096#discussion_r310344340 ########## File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java ########## @@ -72,6 +74,7 @@ private static final int CURRENT_TIME = 1450418597; private static IScheduler scheduler = null; + enum sharedMemoryTypes {sharedOffHeapNodeType, sharedOffHeapWorkerType, sharedOnHeapType}; Review comment: Nit: Please use a more Java-ish style. ``` private enum SharedMemoryTypes { SHARED_OFFHEAP_NODE_TYPE, SHARED_OFFHEAP_WORKER_TYPE, SHARED_ONHEAP_TYPE } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services