storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] krichter722 commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings
Date Fri, 16 Aug 2019 17:53:10 GMT
krichter722 commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle
warnings
URL: https://github.com/apache/storm/pull/3050#discussion_r314820220
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/daemon/drpc/RequestFactory.java
 ##########
 @@ -21,5 +21,6 @@
 import org.apache.storm.generated.DRPCRequest;
 
 public interface RequestFactory<T extends OutstandingRequest> {
-    public T mkRequest(String function, DRPCRequest req);
+
+    T mkRequest(String function, DRPCRequest req);
 
 Review comment:
   I'm 99.9% percent sure. I could verify if you want. In case it isn't I would make it a
check because it's a redundant modifier :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message