storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] krichter722 commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings
Date Sat, 10 Aug 2019 17:51:21 GMT
krichter722 commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle
warnings
URL: https://github.com/apache/storm/pull/3050#discussion_r312710743
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/pacemaker/PacemakerServer.java
 ##########
 @@ -90,6 +90,7 @@ public PacemakerServer(IServerMessageHandler handler, Map<String, Object>
config
         this.bossEventLoopGroup = new NioEventLoopGroup(1, bossFactory);
         // 0 means DEFAULT_EVENT_LOOP_THREADS
         // https://github.com/netty/netty/blob/netty-4.1.24.Final/transport/src/main/java/io/netty/channel/MultithreadEventLoopGroup.java#L40
+        int maxWorkers = (int) config.get(DaemonConfig.PACEMAKER_MAX_THREADS);
 
 Review comment:
   @d2r I don't get where the line `int maxWorkers` ought to be placed? Above the two comment
lines, below or in between?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message