storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] krichter722 commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings
Date Sat, 10 Aug 2019 17:46:16 GMT
krichter722 commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle
warnings
URL: https://github.com/apache/storm/pull/3050#discussion_r312710620
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/utils/ServerUtils.java
 ##########
 @@ -214,13 +219,6 @@ public static ClientBlobStore getClientBlobStoreForSupervisor(Map<String,
Object
 
     /**
      * Meant to be called only by the supervisor for stormjar/stormconf/stormcode files.
-     *
-     * @param key
-     * @param localFile
-     * @param cb
-     * @throws AuthorizationException
-     * @throws KeyNotFoundException
-     * @throws IOException
 
 Review comment:
   They have have no description and thus no value. Leaving them empty is refused by checkstyle
(which is a good thing imo).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message