storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] Ethanlm commented on a change in pull request #3097: STORM-3475 Add ConstraintSolverStrategy Unit Test
Date Tue, 06 Aug 2019 18:22:26 GMT
Ethanlm commented on a change in pull request #3097: STORM-3475 Add ConstraintSolverStrategy
Unit Test
URL: https://github.com/apache/storm/pull/3097#discussion_r311192057
 
 

 ##########
 File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestConstraintSolverStrategy.java
 ##########
 @@ -194,6 +196,51 @@ protected SolverResult backtrackSearch(SearcherState state) {
         }
     }
 
+    /*
+     * Test scheduling large number of executors and constraints.
+     *
+     * Cluster has sufficient resources for scheduling to succeed but can fail due to StackOverflowError.
+     */
+    @ParameterizedTest
+    @ValueSource(ints = { 5, 20 })
 
 Review comment:
   space: Should be `@ValueSource(ints = {5, 20})` .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message