storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [storm] dandsager1 commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option
Date Mon, 05 Aug 2019 15:17:07 GMT
dandsager1 commented on a change in pull request #3096: STORM-3480 Implement One Worker Per
Executor RAS Option
URL: https://github.com/apache/storm/pull/3096#discussion_r310657125
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/SchedulerAssignmentImpl.java
 ##########
 @@ -45,7 +43,7 @@
      */
     private final Map<ExecutorDetails, WorkerSlot> executorToSlot = new HashMap<>();
     private final Map<WorkerSlot, WorkerResources> resources = new HashMap<>();
-    private final Map<String, Double> nodeIdToTotalSharedOffHeap = new HashMap<>();
+    private final Map<String, Double> nodeIdToTotalSharedOffHeapNode = new HashMap<>();
 
 Review comment:
   Trying to make explicit a distinction between sharedOffHeapWorker and sharedOffHeapNode

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message