srdo commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor
RAS Option
URL: https://github.com/apache/storm/pull/3096#discussion_r310344340
##########
File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java
##########
@@ -72,6 +74,7 @@
private static final int CURRENT_TIME = 1450418597;
private static IScheduler scheduler = null;
+ enum sharedMemoryTypes {sharedOffHeapNodeType, sharedOffHeapWorkerType, sharedOnHeapType};
Review comment:
Nit: Please use a more Java-ish style.
```
private enum SharedMemoryTypes {
SHARED_OFFHEAP_NODE_TYPE,
SHARED_OFFHEAP_WORKER_TYPE,
SHARED_ONHEAP_TYPE
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
|