Return-Path: X-Original-To: apmail-storm-dev-archive@minotaur.apache.org Delivered-To: apmail-storm-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 344101179E for ; Tue, 8 Jul 2014 23:41:29 +0000 (UTC) Received: (qmail 22836 invoked by uid 500); 8 Jul 2014 23:41:29 -0000 Delivered-To: apmail-storm-dev-archive@storm.apache.org Received: (qmail 22788 invoked by uid 500); 8 Jul 2014 23:41:29 -0000 Mailing-List: contact dev-help@storm.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.incubator.apache.org Delivered-To: mailing list dev@storm.incubator.apache.org Received: (qmail 22777 invoked by uid 99); 8 Jul 2014 23:41:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2014 23:41:28 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 08 Jul 2014 23:41:30 +0000 Received: (qmail 22612 invoked by uid 99); 8 Jul 2014 23:41:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2014 23:41:05 +0000 Date: Tue, 8 Jul 2014 23:41:05 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@storm.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (STORM-354) Allow users to pass TEST-TIMEOUT-MS as param for complete-topology MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/STORM-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055675#comment-14055675 ] ASF GitHub Bot commented on STORM-354: -------------------------------------- Github user nsj007 commented on the pull request: https://github.com/apache/incubator-storm/pull/122#issuecomment-48413339 Is there any progress on this. The 5000ms timeout pretty much fails all my test when upgrading from STORM 0.9.01 to apache-storm-0.9.2-incubator > Allow users to pass TEST-TIMEOUT-MS as param for complete-topology > ------------------------------------------------------------------ > > Key: STORM-354 > URL: https://issues.apache.org/jira/browse/STORM-354 > Project: Apache Storm (Incubating) > Issue Type: Improvement > Affects Versions: 0.9.2-incubating > Reporter: Aaron Levin > Priority: Minor > Labels: test > Fix For: 0.9.2-incubating > > Original Estimate: 1h > Remaining Estimate: 1h > > It would be nice if complete-topology allowed a user to pass in the default timeout as a parameter (rather than just setting it as 5000ms). I had a test that kept failing by taking too long. > This PR adds functionality without breaking any existing code. Tests pass. > (PS - not sure if this is the proper way to submit a PR for an apache project. I'm open to feedback. Thanks) -- This message was sent by Atlassian JIRA (v6.2#6252)