Mailing-List: contact dev-help@storm.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@storm.incubator.apache.org
Date: Fri, 25 Jul 2014 14:14:38 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@storm.incubator.apache.org
Message-ID: <JIRA.12720427.1402428946994.44928.1406297678839@arcas>
In-Reply-To: <JIRA.12720427.1402428946994@arcas>
References: <JIRA.12720427.1402428946994@arcas>
Subject: [jira] [Commented] (STORM-348) (Security) Netty SASL Authentication
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/STORM-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074425#comment-14074425 ] 

ASF GitHub Bot commented on STORM-348:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/202#discussion_r15402272
  
    --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
    @@ -57,8 +59,10 @@
         private int messageBatchSize;
         
         private AtomicLong pendings;
    +    
    +    Map storm_conf;
     
    -    MessageBatch messageBatch = null;
    +	MessageBatch messageBatch = null;
    --- End diff --
    
    And please mark the new member variables as private they don't appear to need to be protected or package private.


> (Security) Netty SASL Authentication
> ------------------------------------
>
>                 Key: STORM-348
>                 URL: https://issues.apache.org/jira/browse/STORM-348
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: Robert Joseph Evans
>            Assignee: Raghavendra Nandagopal
>              Labels: security
>         Attachments: Storm-Netty Authentication.pdf
>
>
> Currently The Netty transport does no authentication at all.  You can encrypt the tuples being sent, but that is a huge performance hit for many cases that do not need it.  We should support simple SASL authentication when Netty first connects to an external process.  We probably want to use something similar to what we do for ZK, and generate a random secret for each topology.


--
This message was sent by Atlassian JIRA
(v6.2#6252)