Mailing-List: contact dev-help@storm.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@storm.incubator.apache.org
Date: Mon, 7 Jul 2014 19:36:34 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@storm.incubator.apache.org
Message-ID: <JIRA.12712773.1399444768861.14642.1404761794542@arcas>
In-Reply-To: <JIRA.12712773.1399444768861@arcas>
References: <JIRA.12712773.1399444768861@arcas>
Subject: [jira] [Commented] (STORM-312) 'storm monitor' to monitor
 throughput performance interactively
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/STORM-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054087#comment-14054087 ] 

ASF GitHub Bot commented on STORM-312:
--------------------------------------

Github user danehammer commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/117#discussion_r14617140
  
    --- Diff: storm-core/src/jvm/backtype/storm/utils/Monitor.java ---
    @@ -0,0 +1,211 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package backtype.storm.utils;
    +
    +import backtype.storm.generated.*;
    +
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +
    +public class Monitor {
    +    private static final String WATCH_TRANSFERRED = "transferred";
    +    private static final String WATCH_EMITTED = "emitted";
    +
    +    private int _interval = 4;
    +    private String _topology;
    +    private String _component;
    +    private String _stream;
    +    private String _watch;
    +
    +    private static class MetricsState {
    +        long lastStatted = 0;
    +        long lastTime = 0;
    +    }
    +
    +    private static class Poller {
    +        long startTime = 0;
    +        long pollMs = 0;
    +
    +        public long nextPoll() {
    +            long now = System.currentTimeMillis();
    +            long cycle = (now - startTime) / pollMs;
    +            long wakeupTime = startTime + (pollMs * (cycle + 1));
    +            long sleepTime = wakeupTime - now;
    +            if (sleepTime > 0) {
    +                try {
    +                    Thread.sleep(sleepTime);
    +                } catch (InterruptedException e) {
    +                    e.printStackTrace();
    --- End diff --
    
    Also this wouldn't break out of our do/while loop below, which is probably surprising.


> 'storm monitor' to monitor throughput performance interactively
> ---------------------------------------------------------------
>
>                 Key: STORM-312
>                 URL: https://issues.apache.org/jira/browse/STORM-312
>             Project: Apache Storm (Incubating)
>          Issue Type: New Feature
>            Reporter: Jiahong Li
>              Labels: cmd-line-monitor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> This cmd line tool 'storm monitor' will use Nimbus.Client to get throughput information from Nimbus Server.
> 1)One can specify topology's name, component's name to monitor it's throughput interactively.
> 2) It will statistics 'emit' and/or 'transferred' throughput in a given time window and print it in a given time frequency
> The implementation will be much like yahoo's storm-perf-test (http://yahooeng.tumblr.com/post/64758709722/making-storm-fly-with-netty) 


--
This message was sent by Atlassian JIRA
(v6.2#6252)