Mailing-List: contact dev-help@storm.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@storm.incubator.apache.org
Date: Thu, 24 Jul 2014 20:56:40 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@storm.incubator.apache.org
Message-ID: <JIRA.12694365.1392069406258.40104.1406235400036@arcas>
In-Reply-To: <JIRA.12694365.1392069406258@arcas>
References: <JIRA.12694365.1392069406258@arcas>
Subject: [jira] [Commented] (STORM-239) Supervisor fails in working
 directories whose paths have spaces in them
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/STORM-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073632#comment-14073632 ] 

ASF GitHub Bot commented on STORM-239:
--------------------------------------

Github user apetresc commented on the pull request:

    https://github.com/apache/incubator-storm/pull/188#issuecomment-50076920
  
    Upmerged. There were some conflicts and I reworked it a bit to deal with the new logic, but it still works (and allows tests to run in paths with spaces in them)
    
    Let me know if you want these commits squashed before merging!


> Supervisor fails in working directories whose paths have spaces in them
> -----------------------------------------------------------------------
>
>                 Key: STORM-239
>                 URL: https://issues.apache.org/jira/browse/STORM-239
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>         Environment: Linux
>            Reporter: Adrian Petrescu
>            Priority: Minor
>              Labels: build
>
> This is incredibly minor, but when running the unit tests from a path that has a space somewhere, you get a failure of the form:
> {code}
> 7378 [Thread-5] INFO  backtype.storm.daemon.supervisor - Copying resources at file:/var/lib/jenkins/jobs/Apache%20Storm/workspace/storm-core/target/test-classes/resources to /tmp/265ce1e8-8a68-475a-9d59-ccb599add284/supervisor/stormdist/test-1-0/resources
> 7383 [Thread-5] ERROR backtype.storm.event - Error when processing event
> java.io.FileNotFoundException: Source '/var/lib/jenkins/jobs/Apache%20Storm/workspace/storm-core/target/test-classes/resources' does not exist
> 	at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:866) ~[commons-io-1.4.jar:1.4]
> 	at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:770) ~[commons-io-1.4.jar:1.4]
> 	at org.apache.commons.io.FileUtils.copyDirectory(FileUtils.java:745) ~[commons-io-1.4.jar:1.4]
> 	at backtype.storm.daemon.supervisor$fn__4995.invoke(supervisor.clj:493) ~[classes/:na]
> 	at clojure.lang.MultiFn.invoke(MultiFn.java:172) ~[clojure-1.4.0.jar:na]
> 	at backtype.storm.daemon.supervisor$mk_synchronize_supervisor$this__4902.invoke(supervisor.clj:325) ~[classes/:na]
> 	at backtype.storm.event$event_manager$fn__2530.invoke(event.clj:39) ~[classes/:na]
> 	at clojure.lang.AFn.run(AFn.java:24) ~[clojure-1.4.0.jar:na]
> 	at java.lang.Thread.run(Thread.java:724) ~[na:1.7.0_25]
> 7405 [Thread-5] INFO  backtype.storm.util - Halting process: ("Error when processing an event")
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Storm ............................................. SUCCESS [22.941s]
> [INFO] maven-shade-clojure-transformer ................... SUCCESS [23.513s]
> [INFO] Storm Core ........................................ FAILURE [2:54.488s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:52.857s
> [INFO] Finished at: Mon Feb 10 16:16:28 EST 2014
> [INFO] Final Memory: 29M/262M
> [INFO] ------------------------------------------------------------------------
> {code}
> This can be kind of annoying when (as in my example) a continuous integration system is running tests, since you often don't have full control of the path it chooses to check the source tree out at.


--
This message was sent by Atlassian JIRA
(v6.2#6252)