Return-Path: X-Original-To: apmail-storm-dev-archive@minotaur.apache.org Delivered-To: apmail-storm-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C90B9110CD for ; Thu, 17 Jul 2014 21:19:08 +0000 (UTC) Received: (qmail 69639 invoked by uid 500); 17 Jul 2014 21:19:08 -0000 Delivered-To: apmail-storm-dev-archive@storm.apache.org Received: (qmail 69595 invoked by uid 500); 17 Jul 2014 21:19:08 -0000 Mailing-List: contact dev-help@storm.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.incubator.apache.org Delivered-To: mailing list dev@storm.incubator.apache.org Received: (qmail 69584 invoked by uid 99); 17 Jul 2014 21:19:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jul 2014 21:19:07 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 17 Jul 2014 21:19:09 +0000 Received: (qmail 69339 invoked by uid 99); 17 Jul 2014 21:18:43 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jul 2014 21:18:43 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 6545F8C149D; Thu, 17 Jul 2014 21:18:43 +0000 (UTC) From: revans2 To: dev@storm.incubator.apache.org Reply-To: dev@storm.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-storm pull request: [STORM-254] one Spout/Bolt can regis... Content-Type: text/plain Message-Id: <20140717211843.6545F8C149D@tyr.zones.apache.org> Date: Thu, 17 Jul 2014 21:18:43 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user revans2 commented on the pull request: https://github.com/apache/incubator-storm/pull/176#issuecomment-49367057 I am sorry it has taken me so long to look at this. The code change looks good. It would be nice to have a unit test for this, but I don't think it is that critical. I am +1 for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---