Mailing-List: contact dev-help@storm.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@storm.incubator.apache.org
From: Gvain <git@git.apache.org>
To: dev@storm.incubator.apache.org
Reply-To: dev@storm.incubator.apache.org
References: <git-pr-117-incubator-storm@git.apache.org>
In-Reply-To: <git-pr-117-incubator-storm@git.apache.org>
Subject: [GitHub] incubator-storm pull request: STORM-312 : add storm monitor
 tools ...
Content-Type: text/plain
Message-Id: <20140708034301.A7B57945B2D@tyr.zones.apache.org>
Date: Tue,  8 Jul 2014 03:43:01 +0000 (UTC)

Github user Gvain commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/117#discussion_r14635548
  
    --- Diff: storm-core/src/jvm/backtype/storm/utils/Monitor.java ---
    @@ -0,0 +1,211 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package backtype.storm.utils;
    +
    +import backtype.storm.generated.*;
    +
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +
    +public class Monitor {
    +    private static final String WATCH_TRANSFERRED = "transferred";
    +    private static final String WATCH_EMITTED = "emitted";
    +
    +    private int _interval = 4;
    +    private String _topology;
    +    private String _component;
    +    private String _stream;
    +    private String _watch;
    +
    +    private static class MetricsState {
    --- End diff --
    
    Yes , the MerticState and Poller class are not well fits for Java. I will change them to better fits for Java. 
    But I don't quite see what concurrency features we really needs here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---