From dev-return-3933-apmail-storm-dev-archive=storm.apache.org@storm.incubator.apache.org Wed Jul 2 15:42:15 2014 Return-Path: X-Original-To: apmail-storm-dev-archive@minotaur.apache.org Delivered-To: apmail-storm-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6AC5F1195B for ; Wed, 2 Jul 2014 15:42:15 +0000 (UTC) Received: (qmail 33649 invoked by uid 500); 2 Jul 2014 15:42:10 -0000 Delivered-To: apmail-storm-dev-archive@storm.apache.org Received: (qmail 33598 invoked by uid 500); 2 Jul 2014 15:42:10 -0000 Mailing-List: contact dev-help@storm.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.incubator.apache.org Delivered-To: mailing list dev@storm.incubator.apache.org Received: (qmail 33587 invoked by uid 99); 2 Jul 2014 15:42:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jul 2014 15:42:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 02 Jul 2014 15:42:08 +0000 Received: (qmail 33255 invoked by uid 99); 2 Jul 2014 15:41:48 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jul 2014 15:41:48 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 274B4993C02; Wed, 2 Jul 2014 15:41:48 +0000 (UTC) From: dashengju To: dev@storm.incubator.apache.org Reply-To: dev@storm.incubator.apache.org Message-ID: Subject: [GitHub] incubator-storm pull request: [STORM-254] one Spout/Bolt can regis... Content-Type: text/plain Date: Wed, 2 Jul 2014 15:41:48 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org GitHub user dashengju opened a pull request: https://github.com/apache/incubator-storm/pull/176 [STORM-254] one Spout/Bolt can register metric twice with same name in different timeBucket In a Bolt's prepare method, we can register metrics twice with the same name, using different timeBucketSizeInSecs parameter, like this: --------------------------------------------------------------------------------------- public void prepare(Map stormConf, TopologyContext context) { mapper = new ObjectMapper(); CountMetric cMetric = new CountMetric(); context.registerMetric("JavaBoltCount", cMetric, 120); CountMetric ccMetric = new CountMetric(); context.registerMetric("JavaBoltCount", ccMetric, 60); } ---------------------------------------------------------------------------------------- This is caused by TopologyContext's registerMetric. In TopologyContext, all registered metrics holds in a map defined below: private Map>> _registeredMetrics; timeBucketSizeInSecs ----> __taskId ----> metricName ----> metirc But the same name check just at the innermost layer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dashengju/incubator-storm upstream_master_storm254 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-storm/pull/176.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #176 ---- commit f8c9995ac7f1d5fcdd19b3d0f67f0abd111f320e Author: dashengju Date: 2014-07-02T15:32:30Z resolve storm-254, fobbiden to register same name metrics in different timeBucket ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---