storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STORM-381) Replace broken jquery.tablesorter.min.js to latest (2.17.3)
Date Tue, 01 Jul 2014 16:12:25 GMT

    [ https://issues.apache.org/jira/browse/STORM-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049004#comment-14049004
] 

ASF GitHub Bot commented on STORM-381:
--------------------------------------

Github user d2r commented on the pull request:

    https://github.com/apache/incubator-storm/pull/174#issuecomment-47676377
  
    Version of jquery.tablesorter.min.js matches what is tagged as v2.17.3 in Mottie/tablesorter.
    
    Ran a few word_count topologies and tested sorting on time columns and numerical columns.
 Looks good.
    
    I am +1 on this change, but I am not sure how we document our choice of the MIT license.
    
    @ptgoetz, can you comment?


> Replace broken jquery.tablesorter.min.js to latest (2.17.3)
> -----------------------------------------------------------
>
>                 Key: STORM-381
>                 URL: https://issues.apache.org/jira/browse/STORM-381
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>    Affects Versions: 0.9.2-incubating
>            Reporter: Jungtaek Lim
>
> We're having issue on Storm 0.9.2-incubating, javascript error from Storm UI.
> (It's already issued : STORM-379)
> It's syntax error from jquery.tablesorter.min.js,
> I'm not familiar with javascript, so I've just replaced it to latest version (2.17.3),
and it works!
> I don't have strong reason to use latest version, just resolve problem.
> So reviewers have a reason or issue to not use latest version, surely it can be changed.
> I'll make pull request to continue working on it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message