storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STORM-381) Replace broken jquery.tablesorter.min.js to latest (2.17.3)
Date Mon, 07 Jul 2014 08:25:34 GMT

    [ https://issues.apache.org/jira/browse/STORM-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053434#comment-14053434
] 

ASF GitHub Bot commented on STORM-381:
--------------------------------------

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/incubator-storm/pull/174#issuecomment-48152052
  
    @dashengju I'm happy to help!
    @d2r Please see https://github.com/apache/incubator-storm/blob/master/LICENSE.
    257 Line from current master, TableSorted is already documented but outdated for this
PR.
    I think we could be safe with only replacing version because Mottie/tablesorter uses same
license.
    https://github.com/Mottie/tablesorter#licensing
    If you think I am on the right track, please give me your feedback. Then I'll update LICENSE
file. :)


> Replace broken jquery.tablesorter.min.js to latest (2.17.3)
> -----------------------------------------------------------
>
>                 Key: STORM-381
>                 URL: https://issues.apache.org/jira/browse/STORM-381
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>    Affects Versions: 0.9.2-incubating
>            Reporter: Jungtaek Lim
>
> We're having issue on Storm 0.9.2-incubating, javascript error from Storm UI.
> (It's already issued : STORM-379)
> It's syntax error from jquery.tablesorter.min.js,
> I'm not familiar with javascript, so I've just replaced it to latest version (2.17.3),
and it works!
> I don't have strong reason to use latest version, just resolve problem.
> So reviewers have a reason or issue to not use latest version, surely it can be changed.
> I'll make pull request to continue working on it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message