storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STORM-373) Provide Additional String substitutions for *.worker.childopts
Date Tue, 22 Jul 2014 16:30:40 GMT

    [ https://issues.apache.org/jira/browse/STORM-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070466#comment-14070466
] 

ASF GitHub Bot commented on STORM-373:
--------------------------------------

Github user kishorvpatil commented on the pull request:

    https://github.com/apache/incubator-storm/pull/164#issuecomment-49763807
  
    @d2r Thank you for the comments. I have simplified the function  ```substitute-childopts```,
added docstring and simplified the unit tests. Can you please review it? 


> Provide Additional String substitutions for *.worker.childopts 
> ---------------------------------------------------------------
>
>                 Key: STORM-373
>                 URL: https://issues.apache.org/jira/browse/STORM-373
>             Project: Apache Storm (Incubating)
>          Issue Type: Improvement
>    Affects Versions: 0.9.2-incubating
>            Reporter: Kishor Patil
>              Labels: master
>
> As a storm application developer, I would like to name my GC log uniquely, so
> that the log is not blown away each time the worker restarts.
> Add %WORKER-ID% (worker-id) %STORM-ID% (storm-id) to the substitution whenlaunching the
worker JVM.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message