storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STORM-348) (Security) Netty SASL Authentication
Date Fri, 25 Jul 2014 14:16:39 GMT

    [ https://issues.apache.org/jira/browse/STORM-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074428#comment-14074428
] 

ASF GitHub Bot commented on STORM-348:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/202#discussion_r15402428
  
    --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/SaslMessageToken.java ---
    @@ -0,0 +1,100 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package backtype.storm.messaging.netty;
    +
    +import org.jboss.netty.buffer.ChannelBuffer;
    +import org.jboss.netty.buffer.ChannelBufferOutputStream;
    +import org.jboss.netty.buffer.ChannelBuffers;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +/**
    + * Send and receive SASL tokens.
    + */
    +public class SaslMessageToken {
    +	/** Class logger */
    +	private static final Logger LOG = LoggerFactory
    +			.getLogger(SaslMessageToken.class);
    +
    +	/** Used for client or server's token to send or receive from each other. */
    +	private byte[] token;
    +
    +	/**
    +	 * Constructor used for reflection only.
    +	 */
    +	public SaslMessageToken() {
    +	}
    +
    +	/**
    +	 * Constructor used to send request.
    +	 * 
    +	 * @param token
    +	 *            the SASL token, generated by a SaslClient or SaslServer.
    +	 */
    +	public SaslMessageToken(byte[] token) {
    +		this.token = token;
    +	}
    +
    +	/**
    +	 * Read accessor for SASL token
    +	 * 
    +	 * @return saslToken SASL token
    +	 */
    +	public byte[] getSaslToken() {
    +		return token;
    +	}
    +
    +	/**
    +	 * Write accessor for SASL token
    +	 * 
    +	 * @param token
    +	 *            SASL token
    +	 */
    +	public void setSaslToken(byte[] token) {
    +		this.token = token;
    +	}
    +
    +	int encodeLength() {
    +		return 2+4+token.length;
    +	}
    +
    +	/**
    +	 * encode the current SaslToken Message into a channel buffer
    +	 * SaslTokenMessageRequest is encoded as:
    +	 * identifier .... short(2) always it is -500
    +	 * payload length .... int
    +	 * payload .... byte[] 
    +	 * @throws Exception
    +	 */
    +	ChannelBuffer buffer() throws Exception {
    +		ChannelBufferOutputStream bout = new ChannelBufferOutputStream(
    --- End diff --
    
    Again it looks like you have a mixture of spaces and tabs here.  In general the java files
have just had spaces in them.  But this is fairly minor for a new file.


> (Security) Netty SASL Authentication
> ------------------------------------
>
>                 Key: STORM-348
>                 URL: https://issues.apache.org/jira/browse/STORM-348
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: Robert Joseph Evans
>            Assignee: Raghavendra Nandagopal
>              Labels: security
>         Attachments: Storm-Netty Authentication.pdf
>
>
> Currently The Netty transport does no authentication at all.  You can encrypt the tuples
being sent, but that is a huge performance hit for many cases that do not need it.  We should
support simple SASL authentication when Netty first connects to an external process.  We probably
want to use something similar to what we do for ZK, and generate a random secret for each
topology.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message