storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STORM-200) Proposal for Multilang's Metrics feature
Date Tue, 01 Jul 2014 13:26:24 GMT

    [ https://issues.apache.org/jira/browse/STORM-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048864#comment-14048864
] 

ASF GitHub Bot commented on STORM-200:
--------------------------------------

Github user d2r commented on the pull request:

    https://github.com/apache/incubator-storm/pull/38#issuecomment-47655057
  
    @dashengju, thanks for trying it out.
    
    > But under centos 6, always hang by test-builtin-metrics-2 case. It seems your patch
does not work.
    > 
    > ========== below is the stdout error info ==============================================================
    > 114011 [main] ERROR backtype.storm.metrics-test - Error in cluster
    > java.lang.AssertionError: Test timed out (30000ms)
    
    The hang that was happening on your test should be fixed with the patch.
    
    This time-out error is a different issue that existed before your changes, and it does
not appear to be related to your changes specifically.
    
    I think we should file a separate JIRA for this issue and proceed with this pull request.
  If you agree, would you merge the patch and update your branch so that this pull request
is updated?


> Proposal for Multilang's Metrics feature
> ----------------------------------------
>
>                 Key: STORM-200
>                 URL: https://issues.apache.org/jira/browse/STORM-200
>             Project: Apache Storm (Incubating)
>          Issue Type: New Feature
>            Reporter: DashengJu
>            Priority: Minor
>         Attachments: update.patch
>
>
> Storm 0.9.0.1 exposes a metrics interface to report summary statistics across the full
topology. We can build our own metric, and build metrics consumer to use those statistics.
> But when we use Multilang(ie. Python), we can not use this feature. So we want to summit
a proposal for multilang's metrics. 
> The specifics of the proposal:
> 1. The main idea is: when user want to add a metric statistics in multilang(python) bolt,
>     a) he need first create a metric object and register in ShellBolt's sub-class, 
>     b) then update the metric in Python bolt process through RPC call.
> 2. In Metrics API:
>     a) extend IMetric interface add a method for RPC call:public void updateMetricFromRPC(List<Object>
params);  
>     b) modify IMetric implements, to support updateMetricFromRPC;
> 3. In ShellBolt,
>     a) we have a Map<String, IMetric> to hold user's registered metrics  object;
>     b) we have a method registerMetric(String name, T metric) for user to register their
metris object;
>     c) we have a method handleMetrics(Map action) to handle RPC call from Python process;
> 4) In Multilang protocol: add a command "metrics" for shell process to make RPC call.
The protocol is: {"command":"metrics", "name":"metric-registerd-name", "params":["param-1",
param-2]}
> 5) In storm.py:add rpcMetrics(name, params), user can update remote metric through
this RPC call.
> any suggestions?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message