storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From revans2 <...@git.apache.org>
Subject [GitHub] incubator-storm pull request: STORM-348: Netty SASL Authentication
Date Fri, 25 Jul 2014 15:20:44 GMT
Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/202#discussion_r15406084
  
    --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/SaslNettyClient.java ---
    @@ -0,0 +1,166 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package backtype.storm.messaging.netty;
    +
    +import java.io.IOException;
    +
    +import javax.security.auth.callback.Callback;
    +import javax.security.auth.callback.CallbackHandler;
    +import javax.security.auth.callback.NameCallback;
    +import javax.security.auth.callback.PasswordCallback;
    +import javax.security.auth.callback.UnsupportedCallbackException;
    +import javax.security.sasl.RealmCallback;
    +import javax.security.sasl.RealmChoiceCallback;
    +import javax.security.sasl.Sasl;
    +import javax.security.sasl.SaslClient;
    +import javax.security.sasl.SaslException;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +/**
    + * Implements SASL logic for storm worker client processes.
    + */
    +public class SaslNettyClient {
    +
    +	private static final Logger LOG = LoggerFactory
    +			.getLogger(SaslNettyClient.class);
    +
    +	/**
    +	 * Used to respond to server's counterpart, SaslServer with SASL tokens
    +	 * represented as byte arrays.
    +	 */
    +	private SaslClient saslClient;
    +
    +	/**
    +	 * Create a SaslNettyClient for authentication with servers.
    +	 */
    +	public SaslNettyClient(String topologyName, byte[] token) {
    +		try {
    +			LOG.debug("SaslNettyClient: Creating SASL "
    +					+ SaslUtils.AUTH_DIGEST_MD5
    +					+ " client to authenticate to server ");
    +
    +			saslClient = Sasl.createSaslClient(
    +					new String[] { SaslUtils.AUTH_DIGEST_MD5 }, null, null,
    +					SaslUtils.DEFAULT_REALM, SaslUtils.getSaslProps(),
    +					new SaslClientCallbackHandler(topologyName, token));
    +
    +		} catch (IOException e) {
    +			LOG.error("SaslNettyClient: Could not obtain topology token for Netty "
    +					+ "Client to use to authenticate with a Netty Server.");
    +			saslClient = null;
    --- End diff --
    
    I'm not sure we want to fall back to this on an error.  Because when we try to connect
we will end up with NPEs.  Also we don't log the IOException which may make debugging difficult.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message