storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From revans2 <...@git.apache.org>
Subject [GitHub] incubator-storm pull request: STORM-348: Netty SASL Authentication
Date Fri, 25 Jul 2014 14:14:06 GMT
Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/202#discussion_r15402272
  
    --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
    @@ -57,8 +59,10 @@
         private int messageBatchSize;
         
         private AtomicLong pendings;
    +    
    +    Map storm_conf;
     
    -    MessageBatch messageBatch = null;
    +	MessageBatch messageBatch = null;
    --- End diff --
    
    And please mark the new member variables as private they don't appear to need to be protected
or package private.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message