storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From revans2 <...@git.apache.org>
Subject [GitHub] incubator-storm pull request: nodejs multilang protocol implementa...
Date Thu, 24 Jul 2014 21:58:36 GMT
Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/177#issuecomment-50084060
  
    The idea is definitely interesting.  I have a few suggestions though.
    
    The first is with the 'done' callback.  I can see how it is needed to support async processing,
but for me it feels like it is not likely to be too common, but then again I have not done
anything significant with javascript and nothing with nodejs so I just don't know with the
libraries are like.
    
    My other issue is around packaging and testing.  If we are going to officially support
nodejs as an execution environment similar to how we support python and ruby I would like
to see us running unit tests with it like we do with python and ruby.  I would also like to
see it packaged and distributed with storm, and not in the resources of storm-starter.
    
    Alternatively we could set it up as a separate jar similar to the kafka spout, that would
have the storm.js in the resources directory, and then ask users to add it as a maven dependency
when packaging their own topologies.  Either way though I would like to see us test this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message