storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From revans2 <...@git.apache.org>
Subject [GitHub] incubator-storm pull request: STORM-87 fail fast on ShellBolt exce...
Date Tue, 01 Jul 2014 18:16:49 GMT
Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/46#discussion_r14420063
  
    --- Diff: storm-core/src/jvm/backtype/storm/task/ShellBolt.java ---
    @@ -241,5 +241,8 @@ private void handleEmit(Map action) throws InterruptedException {
     
         private void die(Throwable exception) {
             _exception = exception;
    +        LOG.info("Halting process: ShellBolt died.", exception);
    +        _collector.reportError(exception);
    +        Runtime.getRuntime().halt(11);
    --- End diff --
    
    Now that we have ways of cleanly handling System.exit, can we switch over to that instead
of Runtime.halt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message