From dev-return-777-apmail-storm-dev-archive=storm.apache.org@storm.incubator.apache.org Thu Feb 27 05:00:56 2014 Return-Path: X-Original-To: apmail-storm-dev-archive@minotaur.apache.org Delivered-To: apmail-storm-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 120CE10CF0 for ; Thu, 27 Feb 2014 05:00:56 +0000 (UTC) Received: (qmail 68747 invoked by uid 500); 27 Feb 2014 05:00:55 -0000 Delivered-To: apmail-storm-dev-archive@storm.apache.org Received: (qmail 68516 invoked by uid 500); 27 Feb 2014 05:00:48 -0000 Mailing-List: contact dev-help@storm.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@storm.incubator.apache.org Delivered-To: mailing list dev@storm.incubator.apache.org Received: (qmail 68438 invoked by uid 99); 27 Feb 2014 05:00:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Feb 2014 05:00:45 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 27 Feb 2014 05:00:42 +0000 Received: (qmail 68227 invoked by uid 99); 27 Feb 2014 05:00:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Feb 2014 05:00:20 +0000 Date: Thu, 27 Feb 2014 05:00:20 +0000 (UTC) From: "P. Taylor Goetz (JIRA)" To: dev@storm.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (STORM-70) use zookeeper-3.4.5 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/STORM-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914072#comment-13914072 ] P. Taylor Goetz commented on STORM-70: -------------------------------------- I looked into this a bit, but not too far. With the curator versions that are compatible with zookeeper 3.4.x, things seemed to have changed a bit. (Specifically in our unit tests) We make a lot of calls to backtype.storm.utils.Utils.newCurator(), which creates a new (and expensive) {{CuratorFrameWork}} with every invocation. According to the Curator documentation [1], a {{CuratorFramework}} instance should only be created once for each distinct zookeeper quorum/cluster. In unit tests we're creating an insane number of {{CuratorFramework}} instances and never closing them. - Taylor [1] http://curator.apache.org/getting-started.html > use zookeeper-3.4.5 > ------------------- > > Key: STORM-70 > URL: https://issues.apache.org/jira/browse/STORM-70 > Project: Apache Storm (Incubating) > Issue Type: Improvement > Reporter: James Xu > Priority: Minor > Attachments: STORM-70-1.patch > > > zookeeper 3.4.5 is commonly used in production. > And a number of critical bugs exit in 3.3.3. -- This message was sent by Atlassian JIRA (v6.1.5#6160)