storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STORM-186) Milliseconds level tick tuple is broken
Date Wed, 19 Feb 2014 22:43:25 GMT

    [ https://issues.apache.org/jira/browse/STORM-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906226#comment-13906226
] 

ASF GitHub Bot commented on STORM-186:
--------------------------------------

Github user nathanmarz commented on the pull request:

    https://github.com/apache/incubator-storm/pull/37#issuecomment-35559150
  
    Ah yes you're right. The only change I'd like to see is (long (* 1000 secs)) to (long
(* (long 1000) secs)). I know that in Clojure the 1000 is already a long, so it should be
fine, but it's good to be explicit (after all in a prior version of Clojure it would have
been an int). After that change I'm +1.


> Milliseconds level tick tuple is broken
> ---------------------------------------
>
>                 Key: STORM-186
>                 URL: https://issues.apache.org/jira/browse/STORM-186
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: James Xu
>
> dicussed here:http://mail-archives.apache.org/mod_mbox/incubator-storm-user/201312.mbox/%3CCAO%2Bnwyu4pcwarsY-GE%3DKz4GfjoRJCDC5fM6eOyYEkwj9WiJvJA%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message