storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "P. Taylor Goetz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STORM-70) use zookeeper-3.4.5
Date Thu, 27 Feb 2014 05:00:20 GMT

    [ https://issues.apache.org/jira/browse/STORM-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914072#comment-13914072
] 

P. Taylor Goetz commented on STORM-70:
--------------------------------------

I looked into this a bit, but not too far.

With the curator versions that are compatible with zookeeper 3.4.x, things seemed to have
changed a bit.

(Specifically in our unit tests) We make a lot of calls to backtype.storm.utils.Utils.newCurator(),
which creates a new (and expensive) {{CuratorFrameWork}} with every invocation.

According to the Curator documentation [1], a {{CuratorFramework}} instance should only be
created once for each distinct zookeeper quorum/cluster. In unit tests we're creating an insane
number of {{CuratorFramework}} instances and never closing them.

- Taylor

[1] http://curator.apache.org/getting-started.html

> use zookeeper-3.4.5
> -------------------
>
>                 Key: STORM-70
>                 URL: https://issues.apache.org/jira/browse/STORM-70
>             Project: Apache Storm (Incubating)
>          Issue Type: Improvement
>            Reporter: James Xu
>            Priority: Minor
>         Attachments: STORM-70-1.patch
>
>
> zookeeper 3.4.5 is commonly used in production.
> And a number of critical bugs exit in 3.3.3.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message